Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get path to modified collections in object notifications #7356

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 20, 2024

What, How & Why?

Fixes #7320
You can get path infomation from object notifications only.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@jedelbo
Copy link
Contributor Author

jedelbo commented Feb 20, 2024

@rorbech you may want to try this out

@jedelbo jedelbo force-pushed the je/change-key-path branch 3 times, most recently from abfc71f to f92baa3 Compare February 22, 2024 14:37
@jedelbo jedelbo requested a review from rorbech February 23, 2024 10:22
Base automatically changed from next-major to master February 23, 2024 11:45
@jedelbo jedelbo force-pushed the je/change-key-path branch from f92baa3 to 5f8cca1 Compare March 13, 2024 08:41
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_138

Details

  • 118 of 163 (72.39%) changed or added relevant lines in 16 files are covered.
  • 765 unchanged lines in 41 files lost coverage.
  • Overall coverage decreased (-0.3%) to 91.77%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/collection.hpp 0 1 0.0%
src/realm/obj.hpp 0 3 0.0%
src/realm/object-store/c_api/notifications.cpp 22 33 66.67%
src/realm/dictionary.cpp 7 19 36.84%
src/realm/list.cpp 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
src/realm/object-store/impl/list_notifier.cpp 1 99.0%
src/realm/table_ref.hpp 1 55.81%
test/object-store/audit.cpp 1 99.93%
test/object-store/object.cpp 1 98.85%
src/realm/array_blobs_big.cpp 2 98.72%
src/realm/object-store/sync/sync_session.cpp 2 93.65%
src/realm/query_expression.hpp 2 93.68%
src/realm/sync/network/http.hpp 2 82.41%
src/realm/sync/noinst/server/server_history.cpp 2 67.94%
src/realm/uuid.cpp 2 97.01%
Totals Coverage Status
Change from base Build 2130: -0.3%
Covered Lines: 242808
Relevant Lines: 264584

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key path information for notifications in collections in mixed
1 participant