Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final release as part of GSoC 2024 #62

Merged
merged 18 commits into from
Aug 24, 2024
Merged

Final release as part of GSoC 2024 #62

merged 18 commits into from
Aug 24, 2024

Conversation

Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a CHANGELOG.md file?

Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to put minor stuff like "changed the README" into the CHANGELOG. You only need to put in things that a user would notice. Things like "fix the crash on macos" and "Add extended attributes" should be in there. It's also good form to include a link to the PR(s) for each bullet point.

Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense if there weren't any other changes in 0.2.0. Regarding PRs, it's good that you added them but even better if you make them hyperlinks, like https://raw.githubusercontent.com/asomers/fsx-rs/master/CHANGELOG.md .

Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about extended attributes, #43 ?

@realchonk
Copy link
Owner Author

They were added in 0.2.0, which was the first release ever. There was no 0.1.0 release, so everything from the first commit upto the 0.2.0 release should in theory be counted, but that doesn't make sense IMO. I know it's confusing, but confusion is good marketing.

@realchonk
Copy link
Owner Author

I'll merge this PR right before I release 0.3.0 (probably Thursday).

@realchonk
Copy link
Owner Author

I just realized, that the 26th (the end of GSoC) isn't tomorrow, but on Monday.
Therefore, I'll release 0.3.0 on Saturday (24th).

@realchonk realchonk marked this pull request as ready for review August 24, 2024 20:52
@realchonk
Copy link
Owner Author

Unless you have any objections, I'll merge this in an hour and release 0.3.0.

@realchonk realchonk merged commit 8f6faaa into main Aug 24, 2024
5 checks passed
@realchonk realchonk deleted the gsoc-finale branch August 24, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants