Suppress "this-escape" warnings from generated encoders and decoders #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coders, required for them to compile without warnings in JDK21
…decoder, leaving ghosts references when parsing new message with the same decoder instance - issue 525." This reverts commit 99f3d76.
|
We needed various other changes on the branch we use in production: I'll raise separate branches for the two features we want merged, the last commit also has an issue raised |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
845
to
+846
|
|
||
| //this test was added for issue #525 | ||
| //TODO this test was added to guide the bugfix |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #494
This is the simplest, least invasive solution to avoid warnings on generated classes.