Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive types #206

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcnuttandrew
Copy link

This PR addresses my feature request for more aggressive/descriptive types (#204). I added description blocks to all of the types that are exposed on the main Tooltip component, based on the descriptions in the read me. A follow PR could be made (or done in this one) to make the readme component documentation be generated from these types.

@vercel
Copy link

vercel bot commented Feb 8, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/tooltip/6lbn14yl3
✅ Preview: https://tooltip-git-fork-mcnuttandrew-more-desriptive-types.react-component.now.sh

@vercel vercel bot temporarily deployed to Preview February 8, 2020 21:24 Inactive
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #206   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           3      3           
  Lines          25     25           
  Branches       10     10           
=====================================
  Hits           22     22           
  Misses          3      3
Impacted Files Coverage Δ
src/Tooltip.tsx 83.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a583e82...1c2d005. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Nov 4, 2021

Conflicting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants