Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): value support generics #201

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Jan 20, 2024

@madocto madocto force-pushed the feat-value-generics branch from 01ccaa4 to 9a80bb5 Compare January 20, 2024 14:46
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff3c898) 98.26% compared to head (efa7fc6) 98.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   98.26%   98.29%   +0.02%     
==========================================
  Files           2        2              
  Lines         115      117       +2     
  Branches       27       28       +1     
==========================================
+ Hits          113      115       +2     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Jan 20, 2024

lint 挂了,顺便帮忙看看?

@madocto madocto force-pushed the feat-value-generics branch from b76c1f6 to 92f03e1 Compare January 20, 2024 16:04
@afc163
Copy link
Member

afc163 commented Jan 22, 2024

貌似还是挂的。

@madocto
Copy link
Contributor Author

madocto commented Jan 22, 2024

image
types-ramda 从 0.29 版本开始要求 typescript@5,所以升级了 typescript

@afc163 afc163 merged commit e9f69be into react-component:master Jan 22, 2024
8 checks passed
@madocto madocto deleted the feat-value-generics branch January 22, 2024 03:31
@afc163
Copy link
Member

afc163 commented Jan 22, 2024

antd 里需要升级测试一下:https://github.com/react-component/segmented/releases/tag/v2.3.0

@crazyair crazyair mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants