feat(netcore): implement and use error classification #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff implements and uses error classification to reduce errors to a narrow enumeration set. We keep the original error into the structured log, which helps with debugging what happened in case we cannot map the error that occurred with an enumerated error. We're not using OONI errors because they are a bit weird and have some legacy. In any case, we will be able to map to OONI errors, shall we ever decide to reshaphe the results and submit them as OONI measurements.
bassosimone
added a commit
to rbmk-project/rbmk
that referenced
this pull request
Nov 29, 2024
bassosimone
added a commit
to rbmk-project/rbmk
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff implements and uses error classification to reduce errors to a narrow enumeration set.
We keep the original error into the structured log, which helps with debugging what happened in case we cannot map the error that occurred with an enumerated error.
We're not using OONI errors because they are a bit weird and have some legacy. In any case, we will be able to map to OONI errors, shall we ever decide to reshaphe the results and submit them as OONI measurements.