Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(netcore): Dialer+TLSDialer = Network #3

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

bassosimone
Copy link
Member

This commit takes stock of the fact that having two separate types would complicate sharing code and that, in 2024, TLS is so integral to networking that it is part of the basic networking.

As such, we just refactor Dialer and TLSDialer into a single type called Network and name DialTLSContext the TLS dialing func.

This commit takes stock of the fact that having two separate types
would complicate sharing code and that, in 2024, TLS is so integral
to networking that it *is* part of the basic networking.

As such, we just refactor Dialer and TLSDialer into a single type
called Network and name DialTLSContext the TLS dialing func.
@bassosimone bassosimone merged commit 83b7d69 into main Nov 19, 2024
1 check passed
@bassosimone bassosimone deleted the refactor/unify branch November 19, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant