feat: start implementing cleartext dialing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not quite there yet in terms of emitting events, but we have made some progress towards what we actually need. Loosely base the code on OONI Probe code for now, by cherry picking and going on memory while writing this. Also, document my current doubts regarding whether it would be better to have a unified type for dialing all connections types or whether separate types would be better. For now, keep the separate types and re-evaluate this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not quite there yet in terms of emitting events, but we have made some progress towards what we actually need.
Loosely base the code on OONI Probe code for now, by cherry picking and going on memory while writing this.
Also, document my current doubts regarding whether it would be better to have a unified type for dialing all connections types or whether separate types would be better. For now, keep the separate types and re-evaluate this in the future.