feat: log HTTP req/resp and transport protocol #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff: 1. modifies dohttps.go to log the HTTP req/resp using httpslog 2. modifies slog.go to log the transport protocol 3. while there, updates the dependencies in go.mod/go.sum
bassosimone
added a commit
to rbmk-project/rbmk-project.github.io
that referenced
this pull request
Nov 30, 2024
The protocol field contains the network protocol (e.g., "tcp"). See rbmk-project/dnscore#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff:
modifies dohttps.go to log the HTTP req/resp using httpslog
modifies slog.go to log the transport protocol
while there, uses netipx to convert
net.Addrtonetip.AddrPortwhile there, updates the dependencies in go.mod/go.sum