feat(dnscoretest): add listening customisation points #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset implements saving the local and remote addr for all the transports we support, improving data quality. The changes should be obvious for all protocols but DoH, for which we introduced a lower-level mechanism to collect this info, and namely the HTTPClientDo function, opening up the possibility of advanced customization code to create a connection on the fly. The previous mechanism using HTTPClient is still working as intended. Another minor change is refactoring the structured logging code inside the slog.go and slog_test.go files.
This change allows to customise how we create listening connections with dnscoretest. In turn, this opens up the possibility of reusing this code with custom listeners (e.g., rbmk-project/x/netsim).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to customise how we create listening connections with dnscoretest. In turn, this opens up the possibility of reusing this code with custom listeners (e.g., rbmk-project/x/netsim).