Fix some small Clippy lints + format Cargo.toml #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems like this file was added with the "deprecated" doc-comment. i assume no one has ever used it, and it's not referenced in the code anywhere might be a good idea to remove this in a major release
since the generics are only used once, the compiler knows them already
MarijnS95
reviewed
Sep 5, 2024
Comment on lines
28
to
+29
| /// Deprecated, do not use | ||
| #[deprecated] |
There was a problem hiding this comment.
Suggested change
| /// Deprecated, do not use | |
| #[deprecated] | |
| #[deprecated = "do not use"] |
?
Comment on lines
156
to
161
| Err(e) => { | ||
| if controls.is_empty() || e.kind() != io::ErrorKind::InvalidInput { | ||
| return Err(e); | ||
| } else { | ||
| break; | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
We could've almost written something like break if ... { Err(e) } else { Ok(controls) }; showing that this is the only exit.
There was a problem hiding this comment.
Woah, that works just fine! I'm somewhat unfamiliar with this syntax, so please do check to ensure it's right:
Suggested change
| Err(e) => { | |
| if controls.is_empty() || e.kind() != io::ErrorKind::InvalidInput { | |
| return Err(e); | |
| } else { | |
| break; | |
| } | |
| break; | |
| } | |
| Err(e) => { | |
| break if controls.is_empty() || e.kind() != io::ErrorKind::InvalidInput { | |
| Err(e) | |
| } else { | |
| Ok(controls) | |
| }; |
| @@ -27,9 +27,8 @@ macro_rules! impl_enum_frameintervals { | |||
| if ret.is_err() { | |||
| if v4l2_struct.index == 0 { | |||
| return Err(ret.err().unwrap()); | |||
There was a problem hiding this comment.
No conversion here, can we use if let Err(e) to get rid of the unwrap()?
onkoe
commented
Sep 5, 2024
Comment on lines
28
to
34
| if v4l2_struct.index == 0 { | ||
| return Err(ret.err().unwrap()); | ||
| } else { | ||
| return Ok(frameintervals); | ||
| } | ||
| return Ok(frameintervals); | ||
| } | ||
|
|
||
| if let Ok(frame_interval) = FrameInterval::try_from(v4l2_struct) { |
There was a problem hiding this comment.
Is this what you were thinking about? It's a little scary in the macro, but cargo check is happy!
Suggested change
| if v4l2_struct.index == 0 { | |
| return Err(ret.err().unwrap()); | |
| } else { | |
| return Ok(frameintervals); | |
| } | |
| return Ok(frameintervals); | |
| } | |
| if let Ok(frame_interval) = FrameInterval::try_from(v4l2_struct) { | |
| if let Err(e) = ret { | |
| if v4l2_struct.index == 0 { | |
| return Err(e); | |
| } | |
| return Ok(frameintervals); | |
| } | |
| if let Ok(frame_interval) = FrameInterval::try_from(v4l2_struct) { |
onkoe
commented
Sep 5, 2024
| @@ -26,6 +26,7 @@ pub enum Type { | |||
| MetaOutput = 14, | |||
|
|
|||
| /// Deprecated, do not use | |||
| #[deprecated] | |||
| Private = 0x80, | |||
There was a problem hiding this comment.
I feel like this may not be useful. If you have a better reason than "do not use", it'd work much better here! :D
Suggested change
| Private = 0x80, | |
| #[deprecated(note = "do not use")] | |
| Private = 0x80, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy here! Please let me know if any of these are unwanted changes.