Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions #75

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

albertoandreottiATgmail
Copy link
Contributor

Really simple change to allow the dimensions of the input to be different. In this way, one of the dimensions can be seen as time, so you can build a TDNN(time delay neural network) to work with speech signals.

xscale = net.layers{l}.xscale;
yscale = net.layers{l}.yscale;

z = convn(net.layers{l - 1}.a{j}, ones(xscale, yscale) / (xscale*yscale), 'valid'); % !! replace with variable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please calculate ones(xscale, yscale) / (xscale*yscale) in cnnsetup, put it in the net somewhere (net._meanFilter or similar), use that and remove the comment to replace with var

Moved the averaging filter definition from cnnff to cnnsetup. Now it is
computed only once, during the net setup.
@rasmusbergpalm
Copy link
Owner

Funky.. #76 implements non-square kernels. Did you guys coordinate?

Anyway, same comments apply.
make scale a vector, don't be backwards compatible, fix examples to use new style and add assertions in cnnsetup to verify correct scale (i.e. positive integer vector) in order to fail fast.
Add a test that using non-square and square scale works as intended. (i.e. the outputmaps are the expected size, for a known input the computed output is correct, etc.)

Sorry about the extra feedback btw. I was really busy last time I reviewed.

@rasmusbergpalm
Copy link
Owner

Any updates on this?

@albertoandreottiATgmail
Copy link
Contributor Author

Hi guys,

I believe this is already working in a branch of my clone of the repo. Let
me check :-).

On 11 May 2014 10:01, Rasmus Berg Palm [email protected] wrote:

Any updates on this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/75#issuecomment-42769948
.

José Pablo Alberto Andreotti.
Tel: 54 351 4730292
Móvil: 54351156526363.
MSN: [email protected]
Skype: andreottialberto

@rasmusbergpalm
Copy link
Owner

What's the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants