Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignorelist to local exploit suggester datastore options #19739

Merged
merged 1 commit into from
Dec 16, 2024
+2 −1
Merged

Add ignorelist to local exploit suggester datastore options #19739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/post/multi/recon/local_exploit_suggester.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ def valid_incompatibility_reasons(mod, verify_reasons)
end

def set_module_options(mod)
ignore_list = ['ACTION', 'TARGET'].freeze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: The user setting TARGET to a value globally or locally in the datastore would unintentionally be assigned to the local exploit module that was being tested against

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACTION isn't required with the current implementations, but just future-proofing for a future potential bug if it was wired up

datastore.each_pair do |k, v|
mod.datastore[k] = v
mod.datastore[k] = v unless ignore_list.include?(k.upcase)
end
if !mod.datastore['SESSION'] && session.present?
mod.datastore['SESSION'] = session.sid
Expand Down
Loading