Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use existing input object when calling init_tab_complete" #19716

Merged

Conversation

sjanusz-r7
Copy link
Contributor

@sjanusz-r7 sjanusz-r7 commented Dec 11, 2024

Reverts #19711

The acceptance tests failed on this line:

[write] loadpath test/modules

Which then times out.
Using the Rex Readline input object did not work in this case as expected.
The failing acceptance tests only showed something is wrong after landing the PR. The actions on the original PR were all green.
Reverting.

@dwelch-r7 dwelch-r7 merged commit a63fa68 into master Dec 11, 2024
113 checks passed
@dwelch-r7 dwelch-r7 added the rn-no-release-notes no release notes label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants