Add Reline autocomplete prompt behind feature flag #19403
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Aug 20, 2024
| { | ||
| name: SHOW_AUTOCOMPLETION_PROMPT, | ||
| description: 'When enabled, an autocompletion prompt will be shown when typing in commands', | ||
| requires_restart: true, |
There was a problem hiding this comment.
Maybe this could be false if we update def set(name, value) to have a set-effect like it does for wrapped tables
|
This might add a lot of overhead/noise across the wire to remote targets if this impacts Meterpreter shells |
adfoster-r7
reviewed
Nov 8, 2024
| @@ -28,6 +28,7 @@ class FeatureManager | |||
| MSSQL_SESSION_TYPE = 'mssql_session_type' | |||
| LDAP_SESSION_TYPE = 'ldap_session_type' | |||
| SHOW_SUCCESSFUL_LOGINS = 'show_successful_logins' | |||
| SHOW_AUTOCOMPLETION_PROMPT = 'show_autocompletion_prompt' | |||
There was a problem hiding this comment.
This doesn't seem like the right feature flag name; maybe we just name it what it is:
Suggested change
| SHOW_AUTOCOMPLETION_PROMPT = 'show_autocompletion_prompt' | |
| USE_RELINE = 'use_reline' |
There was a problem hiding this comment.
Also happy with other names, but show_autocompletion_prompt isn't what this PR does anymore I don't think 🤔
There was a problem hiding this comment.
Removed the other cherry-picked commit. The PR now does what it says, but I will need to circle back to it after the Reline library has been merged. Leaving it as draft for now 👍
sjanusz-r7
force-pushed
the
reline-autocomplete-prompt-behind-feature-flag
branch
from
9591233 to
848811e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the Readline to Reline refactor here: #19397
This PR adds a new feature flag, that when enabled, will result in valid options that can be tab-completed to be shown below the currently typed text, same as IRB.
This PR should have no technical impact as it only changes how the UI is presented. It does not change valid tab complete options.
Currently putting this up as a draft but will convert to a normal PR without the initial Readline -> Reline commit once it is merged.
Before
After
true/falseetc.Verification