Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support to test custom payload branches #19390

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Adds support to test custom payload branches #19390

merged 1 commit into from
Aug 21, 2024

Conversation

cgranleese-r7
Copy link
Contributor

@cgranleese-r7 cgranleese-r7 commented Aug 14, 2024 •
edited
Loading

This PR adds support to allow us to test payload branches as part of our CI acceptance testing. If we wanted to test payload changes in Framework before they're merged and released as gems separately, that can now be done by adding a the payload-testing-branch for metasploit-payloads payloads, and/or payload-testing-mettle-branch for Mettle payloads.

Verification

  • CI goes green
  • Code changes are sane
  • Can point the GitHub actions at custom payload branches (WILL REQUIRE GITHUB LABELS TO BE ADDED FIRST)

@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch 2 times, most recently from 717d102 to 7fdc103 Compare August 14, 2024 12:56
@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch from 7fdc103 to 4bea76e Compare August 14, 2024 13:05
@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch from 4bea76e to 5349fbd Compare August 15, 2024 09:06
@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch from 5349fbd to 752fbcf Compare August 21, 2024 08:16
adfoster-r7
adfoster-r7 reviewed Aug 21, 2024
View reviewed changes
.github/workflows/acceptance.yml
@@ -81,10 +91,12 @@ jobs:

runs-on: ${{ matrix.os }}

timeout-minutes: 25
timeout-minutes: 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker; we could make this conditional - so 25 by default, 50 for custom

@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch from 752fbcf to 90ac288 Compare August 21, 2024 13:59
@cgranleese-r7 cgranleese-r7 force-pushed the support-custom-branch-payload-testing branch from 90ac288 to 63ac229 Compare August 21, 2024 14:02
@cgranleese-r7 cgranleese-r7 marked this pull request as ready for review August 21, 2024 15:51
@adfoster-r7 adfoster-r7 changed the title <DRAFT> Adds support to test custom payload branches Adds support to test custom payload branches Aug 21, 2024
@adfoster-r7 adfoster-r7 merged commit 0df07d7 into rapid7:master Aug 21, 2024
73 of 77 checks passed
@adfoster-r7 adfoster-r7 added the rn-no-release-notes no release notes label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfoster-r7 adfoster-r7 adfoster-r7 left review comments

Assignees
No one assigned
Labels
enhancement rn-no-release-notes no release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgranleese-r7 @adfoster-r7