add necessary metadata for bruteforce #19352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Aug 1, 2024
| @@ -11,19 +11,32 @@ class LDAP | |||
| include Metasploit::Framework::LDAP::Client | |||
| include Msf::Exploit::Remote::LDAP | |||
|
|
|||
| # TODO: Verify if we need this additional metadata: https://github.com/rapid7/metasploit-framework/blob/master/lib/metasploit/framework/login_scanner/http.rb#L15-L23 | |||
There was a problem hiding this comment.
We'll need to make sure that the ldaps functionality is implemented correctly here, similar to the above link
zgoldman-r7
force-pushed
the
adjust-ldap-scanner
branch
from
12d2e31 to
29bfc1c
Compare
|
Tested and works as expected: |
Release NotesAdjusts the metadata for the ldap login scanner, adding defaults and adjusting the service and protocol values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the metadata for the ldap login scanner, adding defaults and adjusting the service and protocol values.
To test:
test/ldap)ldap_loginmodule against target and ensure functionality still works