Use timed reads in the apache_activemq_rce_cve_2023_46604 check method #19139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19036 by using #timed_read in the check method so it doesn't hang for 60 seconds when targeting an HTTPS service.
#timed_read
uses the socket's read timeout which defaults to 10 seconds. The current implementation uses a default read timeout of 60 seconds which makes scanning services that don't immediately return data on connection (such as HTTPS servers) very slow.Supersedes #19037 which was repurposing the connection timeout for the purposes of a read timeout.
Verification
List the steps needed to make sure this thing works
time check https://metasploit.com/
Demo