Add upload/download/delete/mkdir/rmdir to smb session

[dwelch-r7]

Merge after rapid7/ruby_smb#262

This PR adds the ability to upload/download/delete/mkdir/rmdir from within the smb session type

Verification Steps

• Get an smb session (enable the session type with `features set smb_session_type true)
• Upload a file with upload <local_file> and upload <local_file> <remote_path>
• Download a file with download <remote_file> and download <remote_file> <local_path>
• Delete a file with `delete <file_name>
• Make a directory with mkdir <directory_name>
• Delete a directory with rmdir <directory_name>
• Deleting a directory with files inside displays a message to the user
• Verify psexec still works

[adfoster-r7]

Does the fd object need closed? 🤔

[adfoster-r7]

Can we ensure this close happens 👀

Side note; I wish the simple client offered a proc based API so all this cleanup would happen automagically

[dwelch-r7]

close is the first thing that happens when calling off to delete

metasploit-framework/lib/rex/proto/smb/simple_client/open_file.rb

Lines 19 to 25 in 3671f9d

	def delete
	begin
	close
	rescue StandardError
	end
	client.delete(name, tree_id)
	end

[cgranleese-r7]

Tested against Windows 10

A couple of the <cmd> -h commands points at the incorrect help output, probably worth double checking them all. I added any I came across while testing below under the corresponding command.

upload

Is the intended functionality to overwrite a file if one exists with the same name? Not familiar with how the SMB client handles that so just curious.

download

remote

local after downloading from session

delete

Noticed that delete -h returns the help output for download

mkdir

mkdir also worked when passing a directory with spaces 👍

mkdir -h returns upload help info:

rmdir

rmdir -h returns download help info:

Note

Not sure if this is an issue and isn't related to this PR but thought I'd call it out. Should ls be taking paths and return the appropriate output for the given path?
Currently if I pass ls a directory it just returns the pwd's ls output, rather than returning the directory I passed ls output:

If that is something we'd want to do, we should also update the output to have the passed path be returned somewhere like here maybe?

SMB (192.168.175.193\my_share\test) > ls
ls (\test) <-- Something like this
==

    #  Type  Name          Created                  Accessed       Written        Changed        Size
    -  ----  ----          -------                  --------       -------        -------        ----
    0  DIR   .             2023-12-13T15:25:18+00:  2024-03-01T11  2024-03-01T11  2024-03-01T11
                           00                       :31:31+00:00   :31:40+00:00   :31:40+00:00
    1  DIR   ..            2023-12-13T15:25:18+00:  2024-03-01T11  2024-03-01T11  2024-03-01T11
                           00                       :31:31+00:00   :31:40+00:00   :31:40+00:00
    2  FILE  smb_test.txt  2024-03-01T11:21:23+00:  2024-03-01T11  2024-03-01T11  2024-03-01T11  5
                           00                       :21:43+00:00   :21:43+00:00   :21:43+00:00

[cgranleese-r7]

Tested ls changes to now take a path. As well as larger uploads and downloads.

ls <path>

upload/download larger files

Uploaded a 2GB file fine. Took quite a while but it did upload correctly.

<cmd> -h

All commands now return the appropriate help output.

[cgranleese-r7]

Apart from some methods needing yard docs, it looks good to me 👍

[cgranleese-r7]

Upload/download completion status, works as expected 👍

[adfoster-r7]

@dwelch-r7 Needs a rebase 👍

[cgranleese-r7]

Tested against Windows 10 and everything I previous tested still worked. Added screenshots for the new additional verification steps below:

Error when running rmdir against a directory that isn't empty

psexec

[adfoster-r7]

Release Notes

This PR adds the ability to upload/download/delete/mkdir/rmdir from within the SMB session type