Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces black/flake8 formatting/linting with ruff and ensures numpy 2.0 compatibility #446

Merged
merged 8 commits into from
Dec 8, 2024

Conversation

remrama
Copy link
Contributor

@remrama remrama commented Oct 9, 2024

This PR replaces Black formatting and flake8 linting with Ruff. In doing so, it ensures NumPy 2.0 compatibility (present and future). Both were discussed in #444.

Main changes:

  • Replaced black/flake8 with ruff in pyproject.toml
  • Replaced black GitHub Action with ruff GitHub action
  • Replaced black with ruff in Contributing sections of docs.
  • Ran ruff's linter and formatter (in case of minor deviations from black and flake8)
  • Ran ruff's numpy 2.0 compatibility enforcer

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (a3fa6fb) to head (2c580c3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          19       19           
  Lines        3360     3360           
  Branches      547      492   -55     
=======================================
  Hits         3311     3311           
  Misses         26       26           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remrama remrama changed the title replaces black/flake8 formatting/linting with ruff and ensures numpy 2.0 compatibility (#444) replaces black/flake8 formatting/linting with ruff and ensures numpy 2.0 compatibility Oct 10, 2024
@raphaelvallat raphaelvallat self-requested a review October 11, 2024 06:22
Copy link
Owner

@raphaelvallat raphaelvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! Approved

@raphaelvallat raphaelvallat merged commit ed957c6 into raphaelvallat:main Dec 8, 2024
12 checks passed
@remrama remrama deleted the remrama/issue444 branch December 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants