Modernize Key Derivation Functions #4455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
commented
Dec 2, 2024
reneme
force-pushed
the
feature/kdf_output
branch
from
550256c to
5e6c547
Compare
reneme
force-pushed
the
feature/kdf_output
branch
2 times, most recently
from
2ef851b to
378a62f
Compare
reneme
force-pushed
the
feature/kdf_output
branch
from
149cd0d to
2f9a4a2
Compare
Pass the parameters from the abstract (user-facing) interface as std::span_s and use the latest convenience tools in the implementations of the KDFs.
reneme
force-pushed
the
feature/kdf_output
branch
2 times, most recently
from
97c0fb4 to
fbd9a7b
Compare
reneme
force-pushed
the
feature/kdf_output
branch
from
fbd9a7b to
f57796e
Compare
|
@randombit Does that mean you're fine with this change? 😅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a private customization point in the
KDFbase class. Passes the parameters from the abstract (user-facing) interface asstd::spanwrappers. And, uses the latest convenience tools in the implementations of the KDFs.Also, this introduces
KDF::derive_key<length>(secret, salt, label)to conveniently obtain the key material as a std::array. And deprecates methods that take raw pointers in favor of the std::span/std::string_view based overloads.This is a first step towards #4449.