Add configure logic for choosing how to perform CT value barriers #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Nice! Thanks for setting this up. There's definitely value in allowing to configure this. Also, I can confirm that this is fixing the ICEs reported in #4444.
I feel that a bit more documentation would be good, though. Not necessarily user-facing; perhaps just briefly discussing the idea of each alternative in a doxygen for the value_barrier.
This was referenced Nov 27, 2024
randombit
force-pushed
the
jack/config-ct-barrier
branch
from
7e5c5c4 to
e30c68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4444 and #4445