Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check_contracts_node handles skip_confirm #396

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Jan 3, 2025

There was a small bug where the skip_confirm was ignored.
Prompting the user to source sustrate-contracts-node.

I have added a very minimal test. It could be improved and made more robust if we were to expand MockCli to include checks for certain prompts not being presented in the CLI. But that is another story.

Thanks to @ltfschoen for reporting.

[sc-2094]

@al3mart al3mart requested a review from AlexD10S January 3, 2025 15:06
@al3mart al3mart added bug Something isn't working ready-for-final-review The PR is ready for final review labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.17%. Comparing base (cbf722a) to head (11af03e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/common/contracts.rs 89.47% 0 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   75.15%   75.17%   +0.01%     
==========================================
  Files          62       62              
  Lines       13820    13835      +15     
  Branches    13820    13835      +15     
==========================================
+ Hits        10386    10400      +14     
  Misses       2082     2082              
- Partials     1352     1353       +1     
Files with missing lines Coverage Δ
crates/pop-cli/src/common/contracts.rs 62.67% <89.47%> (+3.62%) ⬆️

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this

@AlexD10S AlexD10S merged commit ca1cd92 into main Jan 3, 2025
20 checks passed
@AlexD10S AlexD10S deleted the al3mart/fix-skip-confirm branch January 3, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-final-review The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants