refactor: review fixes and improvements #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates the expects and unwraps.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## peter/feat-wallet-integration #390 +/- ##
=================================================================
- Coverage 74.97% 74.96% -0.02%
=================================================================
Files 61 61
Lines 13656 13650 -6
Branches 13656 13650 -6
=================================================================
- Hits 10239 10233 -6
- Misses 2075 2076 +1
+ Partials 1342 1341 -1
|
evilrobot-01
requested review from
peterwht,
AlexD10S and
al3mart
and removed request for
peterwht and
AlexD10S
evilrobot-01
commented
Dec 18, 2024
| @@ -194,14 +194,18 @@ impl UpContractCommand { | |||
| spinner.start("Uploading contract..."); | |||
|
|
|||
| if self.upload_only { | |||
| let result = upload_contract_signed(self.url.as_str(), payload).await; | |||
There was a problem hiding this comment.
Previous versions were less code, but resulted in the need for an expect/unwrap which is eliminated by using a match.
evilrobot-01
commented
Dec 18, 2024
| @@ -344,7 +352,7 @@ impl UpContractCommand { | |||
|
|
|||
| // get the call data and contract code hash | |||
| async fn get_contract_data(&self) -> anyhow::Result<(Vec<u8>, [u8; 32])> { | |||
| let contract_code = get_contract_code(self.path.as_ref()).await?; | |||
There was a problem hiding this comment.
Async unnecessary
evilrobot-01
commented
Dec 18, 2024
| @@ -480,7 +488,6 @@ mod tests { | |||
| #[tokio::test] | |||
| async fn get_upload_and_instantiate_call_data_works() -> anyhow::Result<()> { | |||
| let (contracts_node_process, port, temp_dir) = start_test_environment().await?; | |||
| let localhost_url = format!("ws://127.0.0.1:{}", port); | |||
evilrobot-01
commented
Dec 18, 2024
| @@ -22,13 +22,12 @@ pub async fn request_signature(call_data: Vec<u8>, rpc: String) -> anyhow::Resul | |||
| let transaction_data = TransactionData::new(rpc, call_data); | |||
| // Starts server with port 9090. | |||
| let mut wallet = WalletIntegrationManager::new(ui, transaction_data, Some(9090)); | |||
| let url = wallet.server_url.clone(); | |||
There was a problem hiding this comment.
Removes a few unnecessary clones and simplifys the code.
AlexD10S
approved these changes
Dec 18, 2024
AlexD10S
merged commit b757ac1
into
peter/feat-wallet-integration
13 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and improvements from reviewing #371