Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quilt3.admin.tabulator: get/set open query #4260

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Dec 19, 2024

Description

TODO

  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.35%. Comparing base (e7743a7) to head (1598874).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4260      +/-   ##
==========================================
+ Coverage   38.27%   38.35%   +0.07%     
==========================================
  Files         776      778       +2     
  Lines       34323    34366      +43     
  Branches     5424     5424              
==========================================
+ Hits        13137    13180      +43     
  Misses      20007    20007              
  Partials     1179     1179              
Flag Coverage Δ
api-python 91.34% <100.00%> (+0.05%) ⬆️
catalog 16.87% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nl0 nl0 requested review from Copilot and sir-sigurd December 19, 2024 12:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • api/python/quilt3-admin/queries.graphql: Language not supported
  • docs/api-reference/Admin.md: Evaluated as low risk
  • api/python/quilt3/admin/_graphql_client/init.py: Evaluated as low risk
  • docs/CHANGELOG.md: Evaluated as low risk

@nl0 nl0 marked this pull request as ready for review December 19, 2024 12:53
sir-sigurd
sir-sigurd previously approved these changes Dec 19, 2024
docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/advanced-features/tabulator.md Outdated Show resolved Hide resolved
@nl0 nl0 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit fbab903 Dec 19, 2024
38 checks passed
@nl0 nl0 deleted the quilt3-admin-tab-open-q branch December 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants