Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator open query docs #4259

Closed
wants to merge 8 commits into from

Conversation

drernie
Copy link
Member

@drernie drernie commented Dec 17, 2024

Rewriting to use the term 'open query' instead of 'unrestricted access'.
Also rewrote the docs to see if my understanding is correct.

In particular, my naive understanding was that the reason we originally locked down Tabulator is that any user with full Athena + Lambda permissions would otherwise be able to perform any Tabulator query (I.e., they don't need explicit access to the TabulatorDataCatalog and TabulatorBucket). Is that not true?

@drernie drernie changed the base branch from master to tabulator-feature-flag December 17, 2024 00:43
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.27%. Comparing base (365d4f3) to head (c3c6820).
Report is 7 commits behind head on tabulator-feature-flag.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           tabulator-feature-flag    #4259    +/-   ##
========================================================
  Coverage                   38.27%   38.27%            
========================================================
  Files                         776      776            
  Lines                       34323    34323            
  Branches                     5424     5219   -205     
========================================================
  Hits                        13137    13137            
- Misses                      20007    20643   +636     
+ Partials                     1179      543   -636     
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 16.87% <ø> (ø)
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drernie drernie requested review from Copilot and nl0 December 17, 2024 00:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

docs/advanced-features/tabulator.md:198

  • The section header should be capitalized as '## Open Query' to maintain consistency with other section headers.
## open query
@nl0
Copy link
Member

nl0 commented Dec 17, 2024

In particular, my naive understanding was that the reason we originally locked down Tabulator is that any user with full Athena + Lambda permissions would otherwise be able to perform any Tabulator query (I.e., they don't need explicit access to the TabulatorDataCatalog and TabulatorBucket). Is that not true?

no, it's not

anyone with athena and/or lambda permissions can call tabulator -- sure, but the tabulator itself uses two roles for functioning:

  1. its "own" (lambda) execution role with access to cache and stuff (with no access to the actual data)

  2. the role it gets from the registry and assumes to actually access the data (in unrestricted mode it's the special "unrestricted" role, otherwise it's a catalog user's role)

so even if someone is calling tabulator without the proper setup it will just crash -- return an error, not the data

@drernie
Copy link
Member Author

drernie commented Dec 17, 2024

So... stupid question: why do we even need "restricted" mode?

@nl0
Copy link
Member

nl0 commented Dec 17, 2024

So... stupid question: why do we even need "restricted" mode?

to enforce this:

if someone is calling tabulator without the proper setup it will just crash -- return an error, not the data

in unrestricted mode anyone with access to tabulator data catalog, lambda, a compatible workgroup and special s3 buckets can access data from any stack bucket (with configured tables)

@drernie drernie requested review from Copilot and nl0 December 17, 2024 17:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@nl0
Copy link
Member

nl0 commented Dec 18, 2024

partially merged into #4255

@nl0 nl0 closed this Dec 18, 2024
@nl0 nl0 deleted the tabulator-open-query-docs branch December 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants