-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulator open query docs #4259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tabulator-feature-flag #4259 +/- ##
========================================================
Coverage 38.27% 38.27%
========================================================
Files 776 776
Lines 34323 34323
Branches 5424 5219 -205
========================================================
Hits 13137 13137
- Misses 20007 20643 +636
+ Partials 1179 543 -636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
with new label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
docs/advanced-features/tabulator.md:198
- The section header should be capitalized as '## Open Query' to maintain consistency with other section headers.
## open query
no, it's not anyone with athena and/or lambda permissions can call tabulator -- sure, but the tabulator itself uses two roles for functioning:
so even if someone is calling tabulator without the proper setup it will just crash -- return an error, not the data |
So... stupid question: why do we even need "restricted" mode? |
to enforce this:
in unrestricted mode anyone with access to tabulator data catalog, lambda, a compatible workgroup and special s3 buckets can access data from any stack bucket (with configured tables) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
partially merged into #4255 |
Rewriting to use the term 'open query' instead of 'unrestricted access'.
Also rewrote the docs to see if my understanding is correct.
In particular, my naive understanding was that the reason we originally locked down Tabulator is that any user with full Athena + Lambda permissions would otherwise be able to perform any Tabulator query (I.e., they don't need explicit access to the TabulatorDataCatalog and TabulatorBucket). Is that not true?