Skip to content

Commit

Permalink
Minor Athena page UI simplifications (#4232)
Browse files Browse the repository at this point in the history
  • Loading branch information
fiskus authored Nov 20, 2024
1 parent 842e46c commit 7fe641e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions catalog/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ where verb is one of

## Changes

- [Fixed] Athena: fix minor UI bugs ([#4232](https://github.com/quiltdata/quilt/pull/4232))
- [Fixed] Show Athena query editor when no named queries ([#4230](https://github.com/quiltdata/quilt/pull/4230))
- [Fixed] Fix some doc URLs in catalog ([#4205](https://github.com/quiltdata/quilt/pull/4205))
- [Changed] S3 Select -> GQL API calls for getting access counts ([#4218](https://github.com/quiltdata/quilt/pull/4218))
Expand Down
7 changes: 0 additions & 7 deletions catalog/app/containers/Bucket/Queries/Athena/Database.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,8 @@ const useStyles = M.makeStyles((t) => ({
display: 'flex',
},
field: {
cursor: 'pointer',
flexBasis: '50%',
marginRight: t.spacing(2),
'& input': {
cursor: 'pointer',
},
'& > *': {
cursor: 'pointer',
},
},
button: {
marginLeft: t.spacing(1),
Expand Down
8 changes: 7 additions & 1 deletion catalog/app/containers/Bucket/Queries/Athena/History.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,13 @@ export default function History({ bucket, executions, onLoadMore }: HistoryProps
const { workgroup } = Model.use()
if (!Model.hasValue(workgroup)) return null

if (!executions.length)
return (
<M.Paper>
<Empty />
</M.Paper>
)

return (
<>
<M.Paper>
Expand Down Expand Up @@ -304,7 +311,6 @@ export default function History({ bucket, executions, onLoadMore }: HistoryProps
/>
),
)}
{!executions.length && <Empty />}
{(hasPagination || !!onLoadMore) && (
<div className={classes.footer}>
{hasPagination && (
Expand Down

0 comments on commit 7fe641e

Please sign in to comment.