fix: shuffled-index in nested shuffle-contents
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbritz
commented
Nov 28, 2024
MHajoha
reviewed
Dec 2, 2024
MHajoha
added a commit
to questionpy-org/moodle-qtype_questionpy
that referenced
this pull request
Dec 2, 2024
This worked, but only by accident. The $ancestor !== $indexelement was useless. See: questionpy-org/questionpy-sdk#141 (comment)
janbritz
force-pushed
the
fix/shuffled-index-in-shuffle-contents
branch
from
10c5ce0 to
cb9b984
Compare
MHajoha
added a commit
to questionpy-org/moodle-qtype_questionpy
that referenced
this pull request
Dec 3, 2024
This worked, but only by accident. The $ancestor !== $indexelement was useless. See: questionpy-org/questionpy-sdk#141 (comment)
MHajoha
approved these changes
Dec 3, 2024
MHajoha
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In genisteten
shuffle-contentsliegendeshuffled-indexwurden nicht korrekt behandelt.Dieser PR fixt dieses Problem und fügt noch einen Test hinzu.
Das Plugin-Pendant ist hier zu finden.