Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added index for valley in drawdown #681

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thlautenschlaeger
Copy link

without this adaption an error got thrown since valley is an index position and not the index value

@RichardDale
Copy link

RichardDale commented Sep 27, 2021

Hi Thomas - Quantopian staff have been absent from this project for a while and nobody else appears to be administering it.

It has been forked here:
https://github.com/stefan-jansen/pyfolio-reloaded

and it, along with Zipline, is under active development and is compatible with newer Python/Pandas versions.

Perhaps you might want to consider submitting it there too?

Cheers,
Richard.

@thlautenschlaeger
Copy link
Author

Hi Richard,
thanks for your message I'll have a look at pyfolio-reloaded.

Best,
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants