[3860][UPD] dotfiles #218

AungKoKoLin1997 · 2023-03-23T05:43:14Z

yostashiro

Thanks, @AungKoKoLin1997 ! Can you please take this chance to fix tests as well?

yostashiro · 2023-03-23T05:51:13Z

account_analytic_default_product_category/__manifest__.py

 * Do not propose it on Purchase Order lines
    """,
-    'author': 'Rooms For (Hong Kong) Limited T/A OSCG',
-    'website': 'https://www.odoo-asia.com',
+    'author': 'Rooms For (Hong Kong) Limited T/A OSCG, Quartile Limited',


Suggested change

'author': 'Rooms For (Hong Kong) Limited T/A OSCG, Quartile Limited',

'author': 'Quartile Limited',

Rooms For (Hong Kong) Limited is our old company name.

Yes. I thought that is our parent company and I was not sure removing our parent company from author list. I will remove it now.

yostashiro · 2023-03-23T05:52:53Z

product_type_default/__manifest__.py

    'version': '10.0.1.0.0',
    'category': 'Sales',
    'description': """
 * Propose product type from product category
    """,
-    'author': 'Rooms For (Hong Kong) Limited T/A OSCG',
-    'website': 'https://www.odoo-asia.com',
+    'author': 'Rooms For (Hong Kong) Limited T/A OSCG, Quartile Limited',


Suggested change

'author': 'Rooms For (Hong Kong) Limited T/A OSCG, Quartile Limited',

'author': 'Quartile Limited',

yostashiro · 2023-03-23T09:59:34Z

.github/workflows/test.yml

@@ -46,10 +46,18 @@ jobs:
          POSTGRES_DB: odoo
        ports:
          - 5432:5432
+    env:
+      ADDONS_PATH: "/opt/odoo/addons,pci-private"


Actually, it is wrong to have a dependency on a private module. We should move such modules to pci-private, instead of making changes here.

AungKoKoLin1997 · 2023-03-24T10:18:49Z

I have no idea why purchase_received_qty_adj is failed in run tests stage, not in db initialize. I tried to install this module in dev environment and can install. There is no xml error.

codecov-commenter · 2023-03-27T03:57:47Z

Codecov Report

❗ No coverage uploaded for pull request base (10.0@7305226). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4363ae6 differs from pull request most recent head 86394a8. Consider uploading reports for the commit 86394a8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             10.0     #218   +/-   ##
=======================================
  Coverage        ?   53.10%           
=======================================
  Files           ?      230           
  Lines           ?     3188           
  Branches        ?      567           
=======================================
  Hits            ?     1693           
  Misses          ?     1408           
  Partials        ?       87

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AungKoKoLin1997 · 2023-03-27T07:22:39Z

There is only one issue to fix the tests and it's tricky to fix it. So, I think I spend time on this task is enough and will follow up with another task later.

AungKoKoLin1997 · 2024-07-08T03:40:40Z

Tests CI is failed because of stock_shipment_schedule_report depends on website_product_stock that is hosted in pci-private. So, I will follow up for this case because this is not within the scope of this PR.

yostashiro · 2024-07-09T03:20:22Z

product_configurator/__manifest__.py

    'license': 'AGPL-3',
-    'website': 'http://www.pledra.com/',
+    'website': 'https://www.quartile.co',


Let's not force this change.

yostashiro · 2024-07-09T03:21:02Z

product_configurator_mrp/__manifest__.py

    'license': 'AGPL-3',
-    'website': 'http://www.pledra.com/',
+    'website': 'https://www.quartile.co',


Let's not force this change.

yostashiro · 2024-07-09T03:21:13Z

product_configurator_wizard/__manifest__.py

    'license': 'AGPL-3',
-    'website': 'http://www.pledra.com/',
+    'website': 'https://www.quartile.co',


Let's not force this change.

yostashiro · 2024-07-09T03:24:59Z

sale_pricelist_auto_update/tests/test_sale_pricelist_auto_update.py

        )
        cls.date_range = cls.env["date.range"].create(
            {
                "name": "FY2022",
                "date_start": "2022-01-01",
-                "date_end": "2022-12-31",
+                "date_end": fields.date.today(),


Why this change?

I used the wrong approach for fixing tests case. I updated in my latest commit.

yostashiro · 2024-07-09T03:25:12Z

sale_pricelist_auto_update/tests/test_sale_pricelist_auto_update.py

@@ -53,7 +54,7 @@ def test_confirm_and_cancel_sales_order(self):
        yearly_sales_dom = [
            ("partner_id", "=", self.partner.id),
            ("start_date", "=", "2022-01-01"),
-            ("end_date", "=", "2022-12-31"),
+            ("end_date", "=", fields.date.today()),


Why this change?

yostashiro · 2024-07-09T03:29:05Z

website_product_configurator/__manifest__.py

    'license': 'AGPL-3',
-    'website': 'http://www.pledra.com/',
+    'website': 'https://www.quartile.co',


Let's not force this change.

yostashiro · 2024-07-09T03:29:20Z

website_product_configurator_mrp/__manifest__.py

    'license': 'AGPL-3',
-    'website': 'http://www.pledra.com/',
+    'website': 'https://www.quartile.co',


Let's not force this change.

yostashiro · 2024-07-20T10:19:31Z

Tests CI is failed because of stock_shipment_schedule_report depends on website_product_stock that is hosted in pci-private. So, I will follow up for this case because this is not within the scope of this PR.

I'm checking with the client whether stock_shipment_schedule_report is still in use. If it is not, then we can simply put it in the deprecated folder. Otherwise, we want to remove the dependency on website_product_stock from stock_shipment_schedule_report first by creating a bridge module in the pci-private repo. I think it should be relatively simple (I believe the only part that depends on website_product_stock is where consider_qty field appears, if I'm not mistaken).

https://github.com/qrtl/pci-custom/blob/1f17fda/stock_shipment_schedule_report/reports/shipment_schedule_report_compute.py#L181

AungKoKoLin1997 requested review from yostashiro and kanda999 March 23, 2023 05:49

yostashiro reviewed Mar 23, 2023

View reviewed changes

AungKoKoLin1997 force-pushed the 10.0-fix-pre-commit branch from 8719119 to 2201db6 Compare March 27, 2023 07:19

AungKoKoLin1997 force-pushed the 10.0-fix-pre-commit branch 4 times, most recently from 1b1e866 to 001b914 Compare July 8, 2024 03:29

[UPD] dotfiles

e09e09f

AungKoKoLin1997 force-pushed the 10.0-fix-pre-commit branch from 001b914 to e09e09f Compare July 8, 2024 03:29

AungKoKoLin1997 changed the title ~~[FIX] pre-commit~~ [UPD] dotfiles Jul 8, 2024

AungKoKoLin1997 mentioned this pull request Jul 8, 2024

[3860] Dotfiles Update for Repositories: Version 10.0 #220

Closed

AungKoKoLin1997 requested a review from yostashiro July 8, 2024 03:58

yostashiro reviewed Jul 9, 2024

View reviewed changes

yostashiro changed the title ~~[UPD] dotfiles~~ [3860][UPD] dotfiles Jul 9, 2024

upd

d3b8e80

yostashiro mentioned this pull request Jul 29, 2024

[4733][REM] stock_shipment_schedule_report, website_product_configurator, website_product_configurator_mrp, website_sale_view_adj #224

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3860][UPD] dotfiles #218

[3860][UPD] dotfiles #218

AungKoKoLin1997 commented Mar 23, 2023 •

edited by yostashiro

Loading

yostashiro left a comment

yostashiro Mar 23, 2023

AungKoKoLin1997 Mar 23, 2023

yostashiro Mar 23, 2023

yostashiro Mar 23, 2023

AungKoKoLin1997 commented Mar 24, 2023

codecov-commenter commented Mar 27, 2023

AungKoKoLin1997 commented Mar 27, 2023

AungKoKoLin1997 commented Jul 8, 2024

yostashiro Jul 9, 2024

yostashiro Jul 9, 2024

yostashiro Jul 9, 2024

yostashiro Jul 9, 2024

AungKoKoLin1997 Jul 9, 2024

yostashiro Jul 9, 2024

yostashiro Jul 9, 2024

yostashiro Jul 9, 2024

yostashiro commented Jul 20, 2024

	'author': 'Rooms For (Hong Kong) Limited T/A OSCG, Quartile Limited',
	'author': 'Quartile Limited',

[3860][UPD] dotfiles #218

Are you sure you want to change the base?

[3860][UPD] dotfiles #218

Conversation

AungKoKoLin1997 commented Mar 23, 2023 • edited by yostashiro Loading

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AungKoKoLin1997 commented Mar 24, 2023

codecov-commenter commented Mar 27, 2023

Codecov Report

AungKoKoLin1997 commented Mar 27, 2023

AungKoKoLin1997 commented Jul 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro commented Jul 20, 2024

AungKoKoLin1997 commented Mar 23, 2023 •

edited by yostashiro

Loading