Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RootSchema.Unmarshal): permit opaque properties #45

Closed
wants to merge 1 commit into from

Conversation

robfig
Copy link

@robfig robfig commented Apr 5, 2019

add a unit test to verify the behavior

fixes #44

add a unit test to verify the behavior

fixes qri-io#44
@robfig
Copy link
Author

robfig commented Apr 5, 2019

Although, it seems like it's worth adding support for the "definitions" key and returning errors for anything under that which doesn't unmarshal as a schema..

@robfig
Copy link
Author

robfig commented Apr 5, 2019

Yeah.. not sure this is a good idea as-is. Errors parsing children of "properties" and "items" would no longer be reported.

@NikolaLohinski
Copy link

Hi there and thanks for this lib, we really appreciate it !

This feature is a big plus for us, since we need to overload our standard compliant schemas with custom fields. Is there at least a way to set a flag in the rootSchema to enable a kind of "loose" unmarshalling to trigger this behaviour ? The "strict" unmarshalling could still be the default one.

@Arqu
Copy link
Contributor

Arqu commented Aug 3, 2020

Closing this as stale as we moved to a newer draft and re-implemented most of jsonschema.

@Arqu Arqu closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema parsing - Permit opaque key-values in Property schema
3 participants