Add support for PHP 8 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so strange to see that PR is created more that 1 year ago, why did these people are making libraries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have update the composer file and Dockerfile to support PHP 8. The
make testdid succeed, so there should be no breaking changes.Not sure how to handle the Dockerfile though, perhaps multiple stages can be added (i.e. one for php7.1 and one for php8)? The
make buildcommand could be passed the PHP version to build? Feedback is welcome regarding that.It would be very nice if this could be merged, so we can at least use this package with PHP 8.