Early version of using PHPStan for parsing. #1383
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current run on deptrac itself finds new dependencies not found with the old method when calling
parent::method()
by resolving theparent
to the actual class.There are 10_000 things surely wrong with the implementation that need fixing in the next passes, there are no tests, BUT, it works.
Big thanks to @TomasVotruba for Rector and his blog as it allowed me by example to integrate PHPStan DIC to deptrac.
While it does not add much on its own, I see how this might allow us to resolve many open issues in the future, like the oldest open issue #449.