New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update json schemas #559

Merged

jmkerloch merged 4 commits into main from docs/update-json-schemas

Dec 12, 2024

Collaborator

Guts commented Sep 18, 2024 •

edited by jmkerloch

Loading

use new project URLS
since we introduced rules, schema validation is not working anymore (have look upstream Is the project providing an official JSON Schema to validate rules edition? CacheControl/json-rules-engine#366 (comment))
it's systematically failing when used as git hook https://results.pre-commit.ci/run/github/513467425/1732618307.uEV3saFBQmCiG-kNJ9aRNA

github-actions bot added documentation tooling labels

sonarqubecloud bot commented Sep 18, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jmkerloch requested changes

View reviewed changes

docs/schemas/scenario/jobs/qdt_job_base.json Outdated Show resolved Hide resolved

jmkerloch force-pushed the docs/update-json-schemas branch from 7d4b73e to 5f64ca3 Compare

December 12, 2024 07:40

Guts and others added 4 commits

December 12, 2024 09:32


          update(tooling): add new line for JSON files in VS Code

2e6f052


          update(docs): rename and improve some JSON schemas

e71f121


          fix(json schema): remove , from list

86acfd2


          feat(json schema): definition is deprecated, use defs instead

938245b

- https://json-schema.org/draft/2019-09/release-notes#semi-incompatible-changes

jmkerloch force-pushed the docs/update-json-schemas branch from 5f64ca3 to 938245b Compare

December 12, 2024 08:37

sonarqubecloud bot commented Dec 12, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Guts commented

View reviewed changes

Collaborator Author

Guts left a comment

OK, let's cut this one in smaller parts.

jmkerloch approved these changes

View reviewed changes

Collaborator

jmkerloch left a comment

Let's merge to test on main branch !

jmkerloch merged commit 158c419 into main

7 checks passed

jmkerloch deleted the docs/update-json-schemas branch

December 12, 2024 10:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation tooling