LensModel to loop and avoid returning default values & LensModel add tests for sony raw files to avoid default values #1807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description / Motivation and Context
This pull request includes multiple changes to improve the codebase, enhance functionality, and add new tests. The most important changes include namespace adjustments, method reordering, and new test additions.
Codebase Improvements:
IReadMeta.cs
,ReadMetaHelpers/ReadMetaExif.cs
,Services/ReadMeta.cs
). [1] [2] [3]ReadMeta.cs
to improve readability and maintainability. [1] [2] [3] [4] [5]Functional Enhancements:
ReadMetaExif.cs
, including ignoring generic E-mount and T-mount lenses. [1] [2]Make
values by trimming trailing spaces inSetArrayBasedItemsMakeModel
method.GetMakeLensModel
to iterate over directories and avoid returning placeholder values.New Tests:
SonyLensIdConverterTest
to verify the functionality of Sony lens ID conversion methods.ReadMetaExifTest
with a new test method to validate parsing of EXIF directories with example data.ReadMetaSubPathStorageTest
to include a summary comment and improve readability.New Utility Classes:
CreateAnImageA330Raw
andCreateAnImageA6600Raw
to facilitate testing with raw image data. [1] [2]Documentation:
Related Issue
How Has This Been Tested
Types of changes
Checklist