Should create new item instead of re-using it

qdraw · Nov 11, 2024 · 5043e3f · 5043e3f
1 parent 6d0c0df
commit 5043e3f
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/starsky/starsky.foundation.database/Thumbnails/ThumbnailQueryFactory.cs b/starsky/starsky.foundation.database/Thumbnails/ThumbnailQueryFactory.cs
@@ -36,20 +36,19 @@ public ThumbnailQueryFactory(SetupDatabaseTypes? setupDatabaseTypes,
 		}
 
 		var context = _setupDatabaseTypes?.BuilderDbFactory();
-		if ( _thumbnailQuery.GetType() == typeof(ThumbnailQuery) && context != null &&
-		     _memoryCache != null )
+		if ( _thumbnailQuery.GetType() == typeof(ThumbnailQuery) && context != null )
 		{
 			return new ThumbnailQuery(context, _serviceScopeFactory, _logger, _memoryCache);
 		}
 
 		// FakeIQuery should skip creation
 		var isAnyContentIncluded =
-			_thumbnailQuery.GetReflectionFieldValue<List<ThumbnailItem>?>("_content")?.Count != 0;
+			_thumbnailQuery.GetReflectionFieldValue<List<ThumbnailItem>?>("_content") != null;
 
 		if ( !isAnyContentIncluded )
 		{
 			return Activator.CreateInstance(_thumbnailQuery.GetType(),
-				context, _serviceScopeFactory, _logger) as IThumbnailQuery;
+				context, _serviceScopeFactory, _logger, _memoryCache) as IThumbnailQuery;
 		}
 
 		_logger.LogInformation("FakeIThumbnailQuery _content detected");