Mostly improving readability of target_firmware #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerem
reviewed
Oct 11, 2016
| @@ -1590,7 +1610,8 @@ static void ath_draintxq_tgt(void *Context, A_UINT16 Command, | |||
| } | |||
|
|
|||
| static void ath_aborttx_dma_tgt(void *Context, A_UINT16 Command, | |||
| A_UINT16 SeqNo, A_UINT8 *data, a_int32_t datalen) | |||
| A_UINT16 SeqNo, A_UINT8 *data, | |||
| a_int32_t datalen) | |||
There was a problem hiding this comment.
please no style fixes for now.
olerem
reviewed
Oct 11, 2016
| @@ -223,15 +223,15 @@ static a_uint32_t ath_pkt_duration(struct ath_softc_tgt *sc, | |||
|
|
|||
| static void ath_dma_map(struct ath_softc_tgt *sc, struct ath_tx_buf *bf) | |||
| { | |||
| adf_nbuf_t skb = bf->bf_skb; | |||
| adf_nbuf_t skb; | |||
There was a problem hiding this comment.
this should be OK, please make in separate patch. And please provide proper patch format with short log and Signed-of-by: ...
olerem
reviewed
Oct 11, 2016
| @@ -884,14 +884,14 @@ static void ath_tgt_txq_add_ucast(struct ath_softc_tgt *sc, struct ath_tx_buf *b | |||
| { | |||
| struct ath_hal *ah = sc->sc_ah; | |||
| struct ath_txq *txq; | |||
| HAL_STATUS status; | |||
| /*HAL_STATUS status;*/ | |||
There was a problem hiding this comment.
The variable is not used (that is what is reported by cppcheck and it still compiles).
There was a problem hiding this comment.
Sure, commenting out is opposite of clean code.
olerem
suggested changes
Oct 11, 2016
ghost
commented
Oct 20, 2016
| volatile a_int32_t txe_val; | ||
|
|
||
| adf_os_assert(bf); | ||
|
|
||
| txq = bf->bf_txq; | ||
|
|
||
| status = ah->ah_procTxDesc(ah, bf->bf_lastds); | ||
| ah->ah_procTxDesc(ah, bf->bf_lastds); |
Signed-off-by: Nicola Spanti (RyDroid) <[email protected]>
|
I kept some minor style changes. Do you want that I remove all of them too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.