Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention roles & channels #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ynerant
Copy link

@ynerant ynerant commented Feb 14, 2021

This pull request lets optionally to mention roles and channels through IRC. This also adds an option to mention @everyone and @here.

Issues that can be discussed:

  • If the @ROLE is not at the beginning, at the end neither separated by spaces, the role should not be mentioned.
  • Roles and channels are queried at each message. We could store locally a copy of all roles/channels.
  • The structure of channels of Discord is used for mentions. But we can imagine that if multiple channels are bridged on a same guild, names are updated. For example, if I bridge #irc-a to #discord-a and #irc-b to #discord-b, mentioning #irc-a on IRC should display #discord-a on Discord and reciprocally. This is not obvious, and I don't think that it is really needed.

Copy link
Owner

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to always parse @everyone/@here/roles, but use https://discord.com/developers/docs/resources/channel#allowed-mentions-object to prevent the mentions from actually notifying people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants