Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert quant_min/quant_max in embedding4bit #7410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Dec 20, 2024

Fixes #5038

Test plan

CI

Copy link

pytorch-bot bot commented Dec 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7410

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a007d75 with merge base f341da8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2024
@metascroy metascroy changed the title init Assert quant_min/quant_max in embedding4bit Dec 20, 2024
@metascroy
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@metascroy metascroy marked this pull request as ready for review December 20, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The embedding_4bit implementation has a strong assumption about weight_quant_min and weight_quant_max
2 participants