Allow us to move the proto files outside of fbcode #4417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4417
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60187261 |
huydhn
approved these changes
Jul 30, 2024
|
This pull request was exported from Phabricator. Differential Revision: D60187261 |
cantrowitz
force-pushed
the
export-D60187261
branch
from
1d4a2c6 to
97c569e
Compare
cantrowitz
pushed a commit
to cantrowitz/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261
|
This pull request was exported from Phabricator. Differential Revision: D60187261 |
cantrowitz
force-pushed
the
export-D60187261
branch
from
97c569e to
b72d901
Compare
cantrowitz
pushed a commit
to cantrowitz/executorch
that referenced
this pull request
Jul 31, 2024
Summary: Pull Request resolved: pytorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261
Summary: Pull Request resolved: pytorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261
|
This pull request was exported from Phabricator. Differential Revision: D60187261 |
cantrowitz
force-pushed
the
export-D60187261
branch
from
b72d901 to
a2db7b8
Compare
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
|
This pull request has been merged in 5890a9c. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Jul 31, 2024
Summary: X-link: pytorch/executorch#4417 Allow `rust_protobuf_library` to take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed. Reviewed By: ndmitchell, huydhn Differential Revision: D60187261 fbshipit-source-id: 4a044b07d3096e433d987118f363aba42f54f716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow
rust_protobuf_libraryto take in a target or a source. This is an effort to move proto files to a standard, shareable location. The decision was made to make users of this macro to explicitly define the export file if they needed.Reviewed By: ndmitchell
Differential Revision: D60187261