[OSS CI] Introduce periodic.yml #4348
Conversation
Move model tests to periodic. Takes too much resources for each PR. Keep MV3 (CNN) and VIT only.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4348
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 29da380 with merge base fd2dccf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| - cron: 29 8 * * * # about 1:29am PDT, for mem leak check and rerun disabled tests | ||
| push: | ||
| tags: | ||
| - ciflow/periodic/* |
There was a problem hiding this comment.
You'll need to add this into https://github.com/pytorch/executorch/blob/main/.github/pytorch-probot.yml so that the bot can recognize this new tag
|
|
||
| on: | ||
| schedule: | ||
| # We have several schedules so jobs can check github.event.schedule to activate only for a fraction of the runs. |
There was a problem hiding this comment.
I guess you copy this schedule from PyTorch periodic. That workflow has several parts that need to be run with different schedules. ET doesn't need that here, so let's keep only one schedule. PyTorch periodic workflow originally started with every 4 hours, maybe that's a good start or it could be a longer period depending on how frequent a new commit lands in ET trunk https://hud.pytorch.org/hud/pytorch/executorch/main
| @@ -0,0 +1,67 @@ | |||
| name: periodic | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
You might want to add
on:
pull_request:
here just to test the workflow once, then remove the pull_request trigger after before landing. ciflow/periodic won't work on this PR till it's land (chicken and egg issue)
There was a problem hiding this comment.
Triggering it one-off
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
.github/pytorch-probot.yml
Outdated
| @@ -4,3 +4,5 @@ ciflow_push_tags: | |||
| - ciflow/trunk | |||
| - ciflow/binaries | |||
| - ciflow/binaries/all | |||
| - ciflow/periodic | |||
| - ciflow/periodic/all | |||
There was a problem hiding this comment.
Nit: you don't need ciflow/periodic/all, just ciflow/periodic is enough. ciflow/binaries/all is just an outlier, not the norm
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign merged this pull request in 47d309a. |
|
@kirklandsign Why moved to periodic directly? Instead of to trunk first. It's hard to notice any failure in a timely manner on those models once moved to periodic. |
They are still in trunk. Just want to try the periodic workflow. |
Move model tests to periodic. Takes too much resources for each PR. Keep MV3 (CNN) and VIT only.
Later, we can migrate Android on-device related tests to periodic.