Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights to model outputs #4302

Closed
wants to merge 1 commit into from

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Differential Revision: D59929421

Copy link

pytorch-bot bot commented Jul 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4302

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5316987 with merge base 34c3c3d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 24, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 25, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 30, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Aug 1, 2024
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
Summary:
Pull Request resolved: pytorch#4302

Added a pass that flags weights with associated gradients and adds them to the models outputs. Updated the emitter to handle that something could be both a 'constant' and have an allocation_info

Reviewed By: tarun292

Differential Revision: D59929421
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59929421

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 301a017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants