Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant generate_*_compile_spec funcs #3869

Closed
wants to merge 1 commit into from
Closed

Remove redundant generate_*_compile_spec funcs #3869

wants to merge 1 commit into from

Conversation

robell
Copy link
Collaborator

@robell robell commented Jun 6, 2024

tidying up a redundant wrapper function.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3869

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 7c50e7a with merge base 11407f0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2024
@robell robell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jun 6, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Jun 6, 2024
@robell robell force-pushed the tidy-compilespec branch from 1dbea58 to 6460896 Compare June 6, 2024 11:07
@robell robell requested a review from freddan80 June 6, 2024 12:21
@robell robell force-pushed the tidy-compilespec branch from 6460896 to 70f2a37 Compare June 6, 2024 12:49
@robell robell requested a review from digantdesai June 7, 2024 08:47
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Rebase please?

1 similar comment
@digantdesai
Copy link
Contributor

Rebase please?

@robell robell force-pushed the tidy-compilespec branch from 70f2a37 to 72e4dab Compare July 26, 2024 13:30
@robell robell force-pushed the tidy-compilespec branch from 72e4dab to 7c50e7a Compare July 26, 2024 13:31
@robell
Copy link
Collaborator Author

robell commented Jul 29, 2024

@digantdesai this was rebased

I don't think the mac testing failures are related to arm backend changes.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 7f6a341.

@robell robell deleted the tidy-compilespec branch July 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddan80 freddan80 freddan80 approved these changes

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robell @facebook-github-bot @digantdesai @freddan80