Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Allwinner 2013 naming scheme support for A-Series. #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Allwinner 2013 naming scheme support for A-Series. #137

wants to merge 2 commits into from

Conversation

kolyneh
Copy link

@kolyneh kolyneh commented Feb 21, 2023

Allwinner updated their naming scehme since 2013:
Allwinner_SoC_Family

The new scheme is sunxiwxpx, the old scheme sunxi is preserved in this PR for compatibility.

@malfet malfet requested a review from Maratyszcza February 21, 2023 09:17
malfet
malfet requested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are build system scripts changes in this PR?
Also, can you please split it into two:

  • One that adds new property
  • One that adds new chipset (could be this PR, based on the name)

@kolyneh
Copy link
Author

kolyneh commented Feb 21, 2023

Thank you, the build system scripts changes in my local machine i'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet requested changes

@Maratyszcza Maratyszcza Awaiting requested review from Maratyszcza

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolyneh @malfet @facebook-github-bot