Use macOS 12 / iOS 15 perflevel sysctls for better cache info on Apple Platforms #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maratyszcza
suggested changes
Jul 26, 2022
src/arm/mach/init.c
Outdated
| @@ -128,7 +182,7 @@ static enum cpuinfo_uarch decode_uarch(uint32_t cpu_family, uint32_t cpu_subtype | |||
| #endif | |||
| } | |||
|
|
|||
| static void decode_package_name(char* package_name) { | |||
| static void decode_hw_machine_package_name(char* package_name) { | |||
There was a problem hiding this comment.
This change looks unrelated. Please revert or move into a separate PR.
| * iOS 15 and macOS Monterey 12 added sysctls to describe configuration information | ||
| * where not all cores are the same (number of cores, cache sizes). | ||
| * | ||
| * Each perflevel sysctl has a prefix of `hw.perflevel??.` where ?? is the |
There was a problem hiding this comment.
Are perflevels reported by OS ordered? cpuinfo orders cores and logical processors from the most performant to the least performance, so cpuinfo_get_core(0) is the the fastest core and cpuinfo_get_core(cpuinfo_get_cores_count() - 1) is the most power-efficient core.
Maratyszcza
suggested changes
Jul 26, 2022
Developer-Ecosystem-Engineering
force-pushed
the
pr/use-perflevel-sysctls
branch
from
44a2c54 to
61b708b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.