fix get_default_partitioning_alpha for >7 objectives #2646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This ensures the approximation hyperparameter (alpha) for approximate box decompositions is less than 1. Differential Revision: D66834901
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66834901 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 198 198
Lines 17892 17892
=======================================
Hits 17890 17890
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
resolves facebook/Ax#2387 |
|
This pull request has been merged in 0d5e131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This ensures the approximation hyperparameter (alpha) for approximate box decompositions is less than 1.
Differential Revision: D66834901