Clean up support for legacy format non-linear constraints #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66003879 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Nov 15, 2024
Summary: Legacy non-linear inequality constraint format has been deprecated since pytorch#1793. Reviewed By: esantorella Differential Revision: D66003879
Summary: This was deprecated and marked for removal in v0.11. Reviewed By: esantorella Differential Revision: D66003588
Summary: Legacy non-linear inequality constraint format has been deprecated since pytorch#1793. Reviewed By: esantorella Differential Revision: D66003879
saitcakmak
force-pushed
the
export-D66003879
branch
from
e0df8da to
561b41d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66003879 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Nov 15, 2024
Summary: Legacy non-linear inequality constraint format has been deprecated since pytorch#1793. Reviewed By: esantorella Differential Revision: D66003879
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 196 196
Lines 17332 17311 -21
==========================================
- Hits 17330 17309 -21
Misses 2 2 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Nov 15, 2024
Summary: Legacy non-linear inequality constraint format has been deprecated since pytorch#1793. Reviewed By: esantorella Differential Revision: D66003879
|
This pull request has been merged in 260f957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Legacy non-linear inequality constraint format has been deprecated since #1793.
Differential Revision: D66003879