Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model getter test helpers #2476

Closed
wants to merge 1 commit into from

Conversation

hvarfner
Copy link
Contributor

Summary: Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (76a59e4) to head (df26920).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2476   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         191      191           
  Lines       16826    16856   +30     
=======================================
+ Hits        16824    16854   +30     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 20, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 20, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 20, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 21, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 21, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Aug 21, 2024
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Differential Revision: D61567453
Summary:
Pull Request resolved: pytorch#2476

Added model getter test helpers, and substituted the re-definitions of the same functions across most info-theoretic acquisition functions.

Reviewed By: Balandat

Differential Revision: D61567453
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61567453

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in dd6448b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants