-
Notifications
You must be signed in to change notification settings - Fork 293
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: The CI is broken due to the recent default Python version upgrade. Hereby we: - Fix soft_actor_critic code change caused by upgrade of gym - Upgrade omegaconf version due to Python and numpy version upgrade - Upgrade detectron2 model version - Move fambench_xlmr to canary_models We are moving fambench_xlmr to canary_models because it depends on fairseq, and fairseq: 1. Depends on omegaconf < 2.1, which is not compatible with Python 3.11 (https://github.com/facebookresearch/fairseq/blob/main/setup.py#L183) 2. Detectron2, on the other hand, requires omegaconf >=2.1 < 2.4, so they can not co-exist. (https://github.com/facebookresearch/detectron2/blob/main/setup.py#L189) We should suggest the owner of fairseq to update their code to adapt to omegaconf >=2.1. Pull Request resolved: #1950 Reviewed By: davidberard98, msaroufim Differential Revision: D49785274 Pulled By: xuzhao9 fbshipit-source-id: e46f56c28359f8a38e09e2b90d8e07d19b68d58a
- Loading branch information
1 parent
4efaebc
commit dc35369
Showing
6 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
git+https://github.com/facebookresearch/detectron2.git@57bdb21 | ||
omegaconf==2.1.1 | ||
git+https://github.com/facebookresearch/detectron2.git@1a4df4d | ||
omegaconf==2.3.0 | ||
numpy |