optparse: Improve Option typing
#13282
Open
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -27,8 +29,8 @@ NO_DEFAULT: tuple[str, ...] | |||
| SUPPRESS_HELP: str | |||
| SUPPRESS_USAGE: str | |||
|
|
|||
| def check_builtin(option: Option, opt, value: str): ... | |||
| def check_choice(option: Option, opt, value: str) -> str: ... | |||
| def check_builtin(option: Option, opt: str, value: str) -> complex: ... | |||
There was a problem hiding this comment.
This can return complex, float, or int. I guess that does indeed simplify to complex but I think it's worth adding a comment.
Suggested change
| def check_builtin(option: Option, opt: str, value: str) -> complex: ... | |
| # Can return complex, float, or int depending on the option's type | |
| def check_builtin(option: Option, opt: str, value: str) -> complex: ... |
| choices: list[str] | tuple[str, ...] | None = None, | ||
| # TODO: callback, callback_args, callback_kwargs must be all supplied or all omitted. Add overloads. | ||
| # Revisit if ParamSpec is ever changed to support non-unpacked args and kwargs. | ||
| callback: Callable[..., Incomplete] | None = None, |
There was a problem hiding this comment.
Should these Incompletes be Any as the correct type cannot currently be represented in the type system?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.